Fix PHP warning for missing runtime.asset.php in production builds#185
Merged
kadamwhite merged 2 commits intodevelopfrom Apr 20, 2026
Merged
Fix PHP warning for missing runtime.asset.php in production builds#185kadamwhite merged 2 commits intodevelopfrom
kadamwhite merged 2 commits intodevelopfrom
Conversation
Agent-Logs-Url: https://github.com/humanmade/authorship/sessions/ed6902dd-413f-4287-942b-aa5ed41c78af Co-authored-by: kadamwhite <442115+kadamwhite@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix warning on missing runtime asset.php file in production build
Fix PHP warning for missing runtime.asset.php in production builds
Apr 16, 2026
kadamwhite
approved these changes
Apr 20, 2026
joehoyle
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In production builds,
build/runtime.asset.phpdoesn't exist, but the code unconditionally tried toincludeit, generating noisy PHP warnings. The HMR runtime file should only be loaded when both the dependency is declared and the file is present.Changes
inc/namespace.php— Reorder and tighten the runtime asset guard inenqueue_assets_for_post:wp-react-refresh-runtimeis in the dependency array first (cheap, no I/O)runtime.asset.phpis readable on disk viais_readable()before attemptinginclude