Skip to content

Restore allowMultipleArguments #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 29, 2019
Merged

Restore allowMultipleArguments #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
14e70bf
Update WPCS version to better reflect version used
mikeselander Mar 23, 2019
5e3e9eb
Re-allow multiple arguments on a multiline function signature
mikeselander Mar 23, 2019
492d12d
Update documentation
mikeselander Mar 23, 2019
4bdeb46
Update spaces into tabs
mikeselander Mar 26, 2019
7f69093
Peg version at 1.2.1
mikeselander Mar 26, 2019
adfc20b
Merge branch 'master' into fix-multiple-arguments
mikeselander Mar 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions HM/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,25 @@

<rule ref="WordPress.WP.TimezoneChange" />

<!--
Restore the ability to have multiple arguments per line

WPCS disallowed this behavior in 1.1.0, but we'd like to keep it until
there is a reason to disallow multiple arguments.
Ref: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/commit/bb8a48671e213a5588a6439ea52411eeefab4b0f
-->
<rule ref="PEAR.Functions.FunctionCallSignature">
<properties>
<property name="allowMultipleArguments" value="true"/>
</properties>
</rule>
<rule ref="PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket">
<severity phpcs-only="true">0</severity>
</rule>
<rule ref="PEAR.Functions.FunctionCallSignature.CloseBracketLine">
<severity phpcs-only="true">0</severity>
</rule>

<!--
HM Rules / HM RULEZZZZ

Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"license": "GPL-2.0-or-later",
"require": {
"php": ">=7.1",
"wp-coding-standards/wpcs": "^1.0.0",
"wp-coding-standards/wpcs": "1.2.1",
"automattic/vipwpcs": "^0.4.0",
"fig-r/psr2r-sniffer": "^0.5.0",
"squizlabs/php_codesniffer": "~3.4.0",
Expand Down