Skip to content

Fix backdrop dismiss on iOS by replacing closedBy property with getAttribute#10

Merged
roborourke merged 2 commits intomainfrom
copilot/fix-backdrop-dismiss-logic
Apr 10, 2026
Merged

Fix backdrop dismiss on iOS by replacing closedBy property with getAttribute#10
roborourke merged 2 commits intomainfrom
copilot/fix-backdrop-dismiss-logic

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 18, 2026

  • Fix iOS Safari compatibility: replace popup.closedBy with popup.getAttribute('closedby') in src/view.js
  • Code review passed with no comments
  • CodeQL security scan: 0 alerts
Original prompt

This section details on the original issue you should resolve

<issue_title>Cannot tap backdrop to dismiss on iOS, dialog.closedBy not supported</issue_title>
<issue_description>Unfortunately dialog.closedBy is not supported by iOS, so the conditional which we use to check whether we need to apply a manual click close event never passes on that platform. We need an interim solution to permit tapping the backdrop to dismiss on safar.</issue_description>

<agent_instructions>Reimplement the close logic to avoid this safari incompatibility as cleanly as possible.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Open WordPress Playground Preview

… property

Co-authored-by: kadamwhite <442115+kadamwhite@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix backdrop dismiss functionality for iOS Fix backdrop dismiss on iOS by replacing closedBy property with getAttribute Mar 18, 2026
Copilot AI requested a review from kadamwhite March 18, 2026 15:10
github-actions bot added a commit that referenced this pull request Mar 31, 2026
github-actions bot added a commit that referenced this pull request Mar 31, 2026
@roborourke roborourke marked this pull request as ready for review April 10, 2026 12:20
github-actions bot added a commit that referenced this pull request Apr 10, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

Playwright E2E Test Results (PHP 8.4, WP latest)

passed  20 passed

Details

stats  20 tests across 3 suites
duration  2 minutes, 21 seconds
commit  fb286bd

@roborourke roborourke merged commit e18fd45 into main Apr 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot tap backdrop to dismiss on iOS, dialog.closedBy not supported

3 participants