Introduce PHPCS, align to HM coding & CI build standards#3
Merged
Conversation
HMCS prefers all functions to be declared within inc/ Plugin main file should be a trigger / declare constants only.
…lder Avoids PHP warning about invalid first name property in register_block_type call.
…ecognizes it as safe
Simplifies function access in template code
…this day This really doesn't make much difference to maintenance....
kadamwhite
force-pushed
the
phpcs
branch
2 times, most recently
from
53ac430 to
ac1c975
Compare
Adjusts output to pass computed values through esc_attr. Results in an empty style attribute in one render path, but that does not impact render and allows us to more easily escape values when they exist than if we continued to pass the value as an `attribute="value;"` pair.
WP standard is that blocks are responsible for their own escaping, since dynamic blocks can render kses-incompatible markup like inline SVG that would be stripped with naive escaping here.
kadamwhite
changed the title
pamprn09
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
composer phpcsscript to run HMCS against projectnamespace.phpandplugin.phpfor parity with HM file organization standards