Skip to content

Comments

Add the bioauth parameters to the chain spec client extension#137

Merged
tonycdot merged 5 commits intomasterfrom
add-cli-args-to-chain-spec
Sep 17, 2021
Merged

Add the bioauth parameters to the chain spec client extension#137
tonycdot merged 5 commits intomasterfrom
add-cli-args-to-chain-spec

Conversation

@tonycdot
Copy link
Contributor

@tonycdot tonycdot commented Sep 16, 2021

Resolves #116.
To do:

  • Fix problem with extension deserialization
  • Test peer

@tonycdot
Copy link
Contributor Author

Test:

ChainSpec CLI arguments Result
no changes no changes works
new fields robonodeUrl, webappUrl no changes works
new fields robonodeUrl, webappUrl without --webapp-url and --robonode-url works
no changes without --webapp-url and --robonode-url no QR code
new fields, corrupted no changes works
new fields, corrupted without --webapp-url and --robonode-url got Error: Service(Other("relative URL without a base"))

@tonycdot tonycdot marked this pull request as ready for review September 16, 2021 17:36
@tonycdot tonycdot force-pushed the add-cli-args-to-chain-spec branch from 26138af to 82522e4 Compare September 17, 2021 10:55
@tonycdot tonycdot force-pushed the add-cli-args-to-chain-spec branch from 82522e4 to bbcdf08 Compare September 17, 2021 11:26
@tonycdot tonycdot enabled auto-merge (squash) September 17, 2021 11:28
@tonycdot tonycdot merged commit 07e342b into master Sep 17, 2021
@tonycdot tonycdot deleted the add-cli-args-to-chain-spec branch September 17, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Add (some of) the bioauth parameters from CLI arguments to the chain spec client extension

3 participants