Switch to camel case for liveness data #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MOZGIII
reviewed
Dec 31, 2021
Contributor
There was a problem hiding this comment.
LGTM, can we also make it so accept the old fields at backward-compat mode?
If it's not too hacky ofc; we'll have to ship this change together with the new webapp, but we can do a trick at the webapp end - ship it first, and then make it so webapp sends both snake and camel case fields in the same request. Then we'll ship that first, and take care of the node upgrades later.
UPD: nvm, we'll have to send both fields at the webapp for some time either way.
dmitrylavrenov
approved these changes
Jan 7, 2022
MOZGIII
approved these changes
Mar 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary for https://github.com/humanode-network/humanode-web-app/pull/47