Bump to polkadot-v0.9.32 #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MOZGIII
reviewed
Nov 23, 2022
MOZGIII
reviewed
Nov 23, 2022
MOZGIII
reviewed
Nov 23, 2022
MOZGIII
reviewed
Nov 23, 2022
MOZGIII
reviewed
Nov 23, 2022
MOZGIII
reviewed
Nov 23, 2022
Contributor
|
I've completed my initial review and left some comments. There are some changes that don't seem to be necessary, and some changes that I've noted I'd like to discuss. I'll take a deeper look into the codebase of the substrate to assert that we have included all the changes. In the meantime, can we switch to using our own branch |
MOZGIII
approved these changes
Nov 23, 2022
Contributor
MOZGIII
left a comment
MOZGIII
left a comment
There was a problem hiding this comment.
Looks good, except we must create a couple of issues to review the new parameters.
Contributor
Author
Created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits diff for substrate:
humanode-network/substrate@locked/humanode-2022-09-21...humanode-network:substrate:locked/humanode-2022-11-23