Skip to content

Tweaks to the developer experience with EVM #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MOZGIII merged 13 commits into from
Aug 8, 2023
Merged

Tweaks to the developer experience with EVM #713

MOZGIII merged 13 commits into from
Aug 8, 2023

Conversation

@MOZGIII
Copy link
Contributor

@MOZGIII MOZGIII commented Aug 4, 2023 •
edited
Loading

This PR has a few changes:

  • Renames the CLI commands from ethereum to evm
  • Switches the dev and testnet genesis to using standard Ethereum BIP44 account generation logic with the standard substrate dev seed
  • Refactors the code to share the implementation of the chainspec and cli commands account generation/visualization.

Overall, this makes it easier to use our node with hardhat, as there are now usable pre-provisioned accounts that can be used for running the tests.

The old way of generating an EVM account is actually broken with respect to how usable it is with various wallets.

@MOZGIII MOZGIII force-pushed the evm-dev-experience branch from 47e22b5 to 2c37bdb Compare August 4, 2023 01:59
@MOZGIII MOZGIII changed the title Rename Ethereum subcommands to EVM Tweaks to the development experience at EVM Aug 4, 2023
@MOZGIII MOZGIII changed the title Tweaks to the development experience at EVM Tweaks to the developer experience with EVM Aug 4, 2023
@MOZGIII MOZGIII requested a review from dmitrylavrenov August 4, 2023 03:13
dmitrylavrenov
dmitrylavrenov reviewed Aug 4, 2023
View reviewed changes
dmitrylavrenov
dmitrylavrenov approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@dmitrylavrenov dmitrylavrenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are clear and useful!

@MOZGIII MOZGIII enabled auto-merge August 4, 2023 07:15
dmitrylavrenov
dmitrylavrenov reviewed Aug 4, 2023
View reviewed changes
@MOZGIII MOZGIII force-pushed the evm-dev-experience branch 2 times, most recently from 7404370 to 251a086 Compare August 8, 2023 20:00
@MOZGIII MOZGIII force-pushed the evm-dev-experience branch from a06946f to 81f9b73 Compare August 8, 2023 21:09
@MOZGIII MOZGIII added this pull request to the merge queue Aug 8, 2023
Merged via the queue into master with commit 431247a Aug 8, 2023
@MOZGIII MOZGIII deleted the evm-dev-experience branch August 8, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmitrylavrenov dmitrylavrenov dmitrylavrenov approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MOZGIII @dmitrylavrenov