Implement test for robonode transport layer with mocked logic#98
Merged
dmitrylavrenov merged 12 commits intomasterfrom Sep 9, 2021
Merged
Implement test for robonode transport layer with mocked logic#98dmitrylavrenov merged 12 commits intomasterfrom
dmitrylavrenov merged 12 commits intomasterfrom
Conversation
MOZGIII
reviewed
Aug 24, 2021
MOZGIII
reviewed
Aug 24, 2021
Contributor
|
Is this still a draft? |
Contributor
|
What's the status of this PR? Please respond here (and not in DMs) so the context is in one place. |
Contributor
Author
As we agreed before we are going to discuss it with you after Disable Block Authoring PR #67 . We haven't had time on Monday. I would like to understand a purpose of tower and way of using it. |
MOZGIII
reviewed
Sep 8, 2021
MOZGIII
reviewed
Sep 8, 2021
crates/robonode-server/src/logic/op_get_facetec_device_sdk_params.rs
Outdated
Show resolved
Hide resolved
MOZGIII
reviewed
Sep 8, 2021
MOZGIII
reviewed
Sep 8, 2021
MOZGIII
reviewed
Sep 9, 2021
MOZGIII
reviewed
Sep 9, 2021
MOZGIII
reviewed
Sep 9, 2021
MOZGIII
reviewed
Sep 9, 2021
MOZGIII
approved these changes
Sep 9, 2021
Contributor
MOZGIII
left a comment
MOZGIII
left a comment
There was a problem hiding this comment.
LGTM, except for that pub
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #95