Skip to content

Conversation

@hadley
Copy link
Contributor

@hadley hadley commented Apr 14, 2023

Not sure why this worked before.

@hadley hadley mentioned this pull request Apr 14, 2023
6 tasks
@billdenney
Copy link
Member

Thanks for this. I'm also confused about why it would have worked before.

I understand the switch to expect_message, but why did you also remove the class specification that ensures the correct message is being captured?

@hadley
Copy link
Contributor Author

hadley commented Apr 14, 2023

I don't know; probably because it failed when it left it in.

@billdenney billdenney merged commit d15bd23 into humanpred:main Apr 15, 2023
@billdenney
Copy link
Member

I checked, and leaving the class check in worked, so I restored it.

@hadley
Copy link
Contributor Author

hadley commented Apr 27, 2023

Just a note that dev testthat will be going to CRAN on May 1 or 2.

@billdenney
Copy link
Member

The updated version of PKNCA was just accepted on CRAN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants