Add tests to lift R-side coverage to its practical maximum#2
Merged
Conversation
Adds tests for the dispatcher's input-coercion and validation paths (unknown method, unsupported matrix mode, 1-D / 3-D arrays), the max_iter parameter, idempotence on already-thin skeletons across all four algorithms, output-border quietude, degenerate small inputs, and larger varied shapes (rings, notched squares). Coverage rises from 95.20% to 99.20%; the two remaining uncovered lines are defensive branches that are unreachable from R-level inputs in R >= 4.0 (R/thin.R:69 dead-codes a 2-D array branch that is shadowed by is.matrix(), src/lee.cpp:42 is a switch default for a 0..3 enum). testthat expectations: 139 (was 38). lintr::lint_package() clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for the dispatcher's input-coercion and validation paths (unknown method, unsupported matrix mode, 1-D / 3-D arrays), the max_iter parameter, idempotence on already-thin skeletons across all four algorithms, output-border quietude, degenerate small inputs, and larger varied shapes (rings, notched squares). Coverage rises from 95.20% to 99.20%; the two remaining uncovered lines are defensive branches that are unreachable from R-level inputs in R >= 4.0 (R/thin.R:69 dead-codes a 2-D array branch that is shadowed by is.matrix(), src/lee.cpp:42 is a switch default for a 0..3 enum).
testthat expectations: 139 (was 38). lintr::lint_package() clean.