Reorganize tfl_table vignettes; document rowspan flow + partial-width rules#33
Merged
Conversation
… rules v02 (intro) was a flat list of sections. Group them into three nested parents — Columns, Rows, Pagination — and move tfl_colspec() under Columns where it belongs. Add a new "Suppression and multi-line group labels" subsection under Rows that documents the HTML-rowspan-style flow introduced for issue 29: when a multi-line group label sits above suppressed cells, it flows downward through them rather than inflating just the labelled row. Cross-reference the v03 sections that describe how rules adapt to the flow. Update the summary table to (a) add previously-missing arguments — row_rule, fill_by, the sub_tfl family — and (b) regroup rows by purpose so the table is scannable. v03 (styling) had a flat numbered 1..14 outline. Drop the manual numbering and group the sections under five logical parents: Typography, Rules and separators, Cell padding, Cell background shading, Multi-page accessories, Sub-tables, Complete examples. Move the column-continuation message under Multi-page accessories where it sits next to the row-continuation marker styling. Update the Group rules subsection to describe the partial-width rendering (rule starts at the column whose value actually changed at the transition, with a worked example for nested group_vars). Update the Row rules subsection to mention the within-span suppression (a rule that would slice a flowing label is omitted, the same way HTML rowspan cells have no internal borders). Both vignettes still render to HTML cleanly via rmarkdown::render(). No code changes; full test suite still passes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v02 (intro) was a flat list of sections. Group them into three nested parents — Columns, Rows, Pagination — and move tfl_colspec() under Columns where it belongs. Add a new "Suppression and multi-line group labels" subsection under Rows that documents the HTML-rowspan-style flow introduced for issue 29: when a multi-line group label sits above suppressed cells, it flows downward through them rather than inflating just the labelled row. Cross-reference the v03 sections that describe how rules adapt to the flow. Update the summary table to (a) add previously-missing arguments — row_rule, fill_by, the sub_tfl family — and (b) regroup rows by purpose so the table is scannable.
v03 (styling) had a flat numbered 1..14 outline. Drop the manual numbering and group the sections under five logical parents: Typography, Rules and separators, Cell padding, Cell background shading, Multi-page accessories, Sub-tables, Complete examples. Move the column-continuation message under Multi-page accessories where it sits next to the row-continuation marker styling. Update the Group rules subsection to describe the partial-width rendering (rule starts at the column whose value actually changed at the transition, with a worked example for nested group_vars). Update the Row rules subsection to mention the within-span suppression (a rule that would slice a flowing label is omitted, the same way HTML rowspan cells have no internal borders).
Both vignettes still render to HTML cleanly via rmarkdown::render(). No code changes; full test suite still passes.