Conversation
There was a problem hiding this comment.
Pull request overview
Adds automated Nerd Fonts installation to the Unix setup flows to improve terminal/editor glyph support during environment bootstrap.
Changes:
- Invoke a new Nerd Fonts install step during macOS setup (non-fatal).
- Invoke a new Nerd Fonts install step during Ubuntu setup for both the current user and root (currently fatal on failure).
- Add OS-specific
install-nerd-fonts.shscripts for macOS (Homebrew) and Ubuntu/Debian (direct download +fc-cache).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/setup/unix/macos/setup-macos.sh |
Adds a Nerd Fonts install step to the macOS setup flow (warn/continue on failure). |
src/setup/unix/macos/install-nerd-fonts.sh |
New macOS Nerd Fonts installer using Homebrew font casks. |
src/setup/unix/linux/ubuntu/setup-ubuntu.sh |
Adds a Nerd Fonts install step for root during Ubuntu setup (currently exits on failure). |
src/setup/unix/linux/ubuntu/install-nerd-fonts.sh |
New Ubuntu/Debian Nerd Fonts installer via GitHub downloads + font cache refresh. |
src/setup/unix/linux/setup-user.sh |
Adds a Nerd Fonts install step during user setup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+30
to
+35
| echo "[INFO]: Installing Nerd Fonts..." | ||
|
|
||
| echo "[INFO]: Installing Ubuntu Mono Nerd Font..." | ||
| brew install font-ubuntu-mono-nerd-font || { | ||
| echo "[WARN]: Failed to install 'Ubuntu Mono Nerd Font', skipping!" >&2 | ||
| } |
src/setup/unix/linux/setup-user.sh
Outdated
Comment on lines
+254
to
+257
| _fetch "setup/unix/linux/ubuntu/install-nerd-fonts.sh" | bash || { | ||
| echo "[ERROR]: Failed to install Nerd Fonts for user '${USERNAME}'!" >&2 | ||
| exit 2 | ||
| } |
Comment on lines
+54
to
+60
| echo "[INFO]: Downloading Ubuntu Mono Nerd Font..." | ||
| rm -vf UbuntuMonoNerdFont-*.ttf || true | ||
| curl -fLO https://github.com/ryanoasis/nerd-fonts/raw/HEAD/patched-fonts/UbuntuMono/Regular/UbuntuMonoNerdFont-Regular.ttf || exit 2 | ||
| curl -fLO https://github.com/ryanoasis/nerd-fonts/raw/HEAD/patched-fonts/UbuntuMono/Bold/UbuntuMonoNerdFont-Bold.ttf || exit 2 | ||
| echo "[OK]: Done." | ||
|
|
||
| echo "[INFO]: Downloading Ubuntu Nerd Font..." |
Comment on lines
+33
to
+38
| for _cmd in curl fc-cache; do | ||
| if ! command -v "${_cmd}" >/dev/null 2>&1; then | ||
| echo "[ERROR]: Not found '${_cmd}' command, please install it first." >&2 | ||
| exit 1 | ||
| fi | ||
| done |
Comment on lines
+270
to
+273
| _fetch "setup/unix/linux/ubuntu/install-nerd-fonts.sh" | ${_SUDO} bash || { | ||
| echo "[ERROR]: Failed to install Nerd Fonts for root user!" >&2 | ||
| exit 2 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds automated installation of Nerd Fonts for both Linux (Ubuntu/Debian) and macOS environments as part of the user and root setup scripts. The changes ensure that popular patched fonts are installed and available for improved terminal and development experience, with platform-specific handling and error checks.
Nerd Fonts installation automation:
install-nerd-fonts.shfor Ubuntu/Debian systems that downloads and installs several Nerd Fonts (Ubuntu Mono, Ubuntu, Roboto Mono, Terminess) and updates the font cache, with checks for required commands and OS/distro compatibility.install-nerd-fonts.shfor macOS that installs the same set of Nerd Fonts using Homebrew, with OS and dependency checks.Integration into setup workflows:
setup-user.sh) to fetch and run the Nerd Fonts installation script for the current user.setup-ubuntu.sh) to fetch and run the Nerd Fonts installation script for the root user.setup-macos.sh) to fetch and run the Nerd Fonts installation script, with a warning if installation fails (does not block the setup).