Skip to content

Conversation

@BrandonTing
Copy link
Contributor

@BrandonTing BrandonTing commented Jan 25, 2025

Closes: #1642

bun 1.2 introduces new lock format: bun.lock, which is not supported by package-manager-detector until 0.2.8.

Before submitting the PR, please make sure you do the following

  • If your PR isn't addressing a small fix (like a typo), it references an issue where it is discussed ahead of time and assigned to you. In many cases, features are absent for a reason.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Format & lint the code with pnpm format and pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Jan 25, 2025

🦋 Changeset detected

Latest commit: 324105a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
shadcn-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ieedan
Copy link
Collaborator

ieedan commented Jan 26, 2025

LGTM!

@BrandonTing BrandonTing changed the title Chore bump package manager detector chore: bump package manager detector Jan 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview 324105a

Copy link
Collaborator

@AdrianGonz97 AdrianGonz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@AdrianGonz97 AdrianGonz97 merged commit 283c5dc into huntabyte:main Apr 16, 2025
4 checks passed
@fjeremic
Copy link

@huntabyte would it be possible cherry-pick this change into the @next version? shadcn-svelte@next uses package-manager-detector v0.2.2 which doesn't have support for detecting Deno, while the version in this PR (v1.2.0) does. When trying to install components using the shadcn-svelte@next cli, it fails to detect the Deno runtime, and it won't install component dependencies because of the code here:

const pm = await detectPM(cwd, options.deps);
if (pm) {
const addCmd = resolveCommand(pm, "add", ["-D", ...PROJECT_DEPENDENCIES])!;
tasks.push({
title: `${highlight(pm)}: Installing dependencies`,
enabled: options.deps,
async task() {
await execa(addCmd.command, addCmd.args, { cwd });
return `Dependencies installed with ${highlight(pm)}`;
},
});
}

Backporting this PR to the @next branch will fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cli: upgrade package-manager-detector to 0.2.8 to improve bun support

5 participants