Skip to content

Conversation

@shyakadavis
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2025

⚠️ No Changeset found

Latest commit: c5fec2d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview c5fec2d
scn-svelte-v4 ✅ Ready (View Log) Visit Preview c5fec2d

@jeroenrinzema
Copy link

@shyakadavis, do you need help wrapping up this component? We have cloned your implementation so far and made some minor improvements but would love to include this component within the official package.

@shyakadavis
Copy link
Contributor Author

shyakadavis commented May 21, 2025

Hey, @jeroenrinzema was waiting till the weekend to get back to this, but please feel free to go ahead. 🙂

If I recall correctly, there were some issues around viewport and Content that were wrong and needed fixing.

In the attached screenshot, for example, you'll notice that the content overflows.

Screenshot 2025-05-21 at 12 20 02

Similar: https://77ecae9d.shadcn-svelte.pages.dev/docs/components/navigation-menu

And as for viewport, I remember seeing a similar remark in Bits. (Let me look for it, will update this comment.)

@huntabyte huntabyte deleted the branch huntabyte:next-tailwind-4 May 23, 2025 15:29
@huntabyte huntabyte closed this May 23, 2025
@huntabyte
Copy link
Owner

I did not mean to close this PR @shyakadavis ! I guess it did so when I deleted my branch

@shyakadavis shyakadavis deleted the chore/navigation-menu branch May 24, 2025 15:45
@shyakadavis
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants