feat: default machine, storage names, sizes, limit on options#235
Merged
Conversation
Contributor
kei5uke
commented
May 22, 2026
kei5uke
commented
- the default machine (home machine) can only have commit_1 or commit_3y options, while additional machines can have all options.
- the default storage size based on the option
- machine names
matuskosut
requested changes
May 22, 2026
| <div class="d-flex ga-2 justify-end"> | ||
| <v-icon color="medium-emphasis" icon="mdi-pencil" size="small" @click="editCompute(selectedCompute.find((c) => c.id === item.id)!)"></v-icon> | ||
| <v-icon color="medium-emphasis" icon="mdi-delete" size="small" @click="removeComputeById(item.id)"></v-icon> | ||
| <v-icon v-show="!item.isDefault" color="medium-emphasis" icon="mdi-delete" size="small" @click="removeComputeById(item.id)"></v-icon> |
Contributor
There was a problem hiding this comment.
here we are hiding the button, but not informing the user why the button is missing. I think we should improve that.
matuskosut
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.