fix: relax protobuf version constraint to support newer versions (closes #76)#78
Open
botbikamordehai2-sketch wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
protobuf~=3.6constraint insetup.pyrestricts protobuf to versions>=3.6, <4.0. This old version of protobuf is incompatible with Python 3.13 and likely fails to properly deserialize the MangaPlus API responses, resulting in emptypageslists and theIndexError: list index out of rangeseen in #76.Fix
Relax the protobuf constraint from
~=3.6to>=3.6to allow installation of newer protobuf versions (4.x, 5.x) that are compatible with Python 3.13 and current API responses.Closes #76