Add confirmation dialogs for start and rotate actions#75
Merged
huseyinbabal merged 1 commit intomasterfrom Jan 14, 2026
Merged
Conversation
- Add confirmation modal to EC2 start instance action (s key) - Add confirmation modal to RDS start instance action (s key) - Add confirmation modal to Secrets Manager rotate secret action (R key) These actions can incur AWS charges or modify state, so they should require user confirmation like other similar actions (stop, reboot, etc.) Closes #74
huseyinbabal
force-pushed
the
feature/start-instance-confirmation
branch
from
e657608 to
ff0e07c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skey)skey)Rkey)Related Issue
Closes #74
Rationale
The user raised a valid concern: pressing
s(start) accidentally instead ofd(details) could start instances and incur unexpected AWS charges. Other state-changing actions like stop (S) and reboot (r) already require confirmation.This PR adds confirmation dialogs to all remaining write/modify operations that were missing them:
ssRType of Change
Checklist