Skip to content

Add view secret value action for secrets manager#91

Merged
huseyinbabal merged 3 commits intohuseyinbabal:masterfrom
ldziedziul:view-secrets
Jan 16, 2026
Merged

Add view secret value action for secrets manager#91
huseyinbabal merged 3 commits intohuseyinbabal:masterfrom
ldziedziul:view-secrets

Conversation

@ldziedziul
Copy link
Contributor

@ldziedziul ldziedziul commented Jan 15, 2026

Press 'x' on a secret to retrieve and display its decrypted value in the JSON viewer.

Related Issue

Closes #90

Description

Adds a new action type show_result for actions that retrieve and display data rather than executing mutations. When triggered, these actions fetch data from AWS and display it in the JSON viewer (Describe mode).

Changes:

  • Added show_result field to ActionDef for read-only actions that return displayable data
  • Implemented execute_action_with_result() in dispatch module for Secrets Manager's GetSecretValue API
  • show_result actions are allowed even in readonly mode since they don't mutate resources
  • The viewer title shows the action name (e.g., "Secret Value") instead of "Details"

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)

Checklist

  • I have linked this PR to an existing issue
  • My code follows the project's code style
  • I have tested my changes locally
  • I have added/updated relevant documentation (if applicable)
  • My changes don't introduce new warnings

Screenshots (if applicable)

image image

Press 'v' on a secret to retrieve and display its decrypted value
in the JSON viewer.
Copy link
Owner

@huseyinbabal huseyinbabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ldziedziul Thanks for the contribution, it works like a charm, but can we use x instead of v to follow convention of k9s? This project is highly inspired from that project and x is used for decoding secrets in k8s and actually I like x key since it is like you are looking at "x files", thanks in advance 🙏

@ldziedziul
Copy link
Contributor Author

@ldziedziul Thanks for the contribution, it works like a charm, but can we use x instead of v to follow convention of k9s? This project is highly inspired from that project and x is used for decoding secrets in k8s and actually I like x key since it is like you are looking at "x files", thanks in advance 🙏

@huseyinbabal sure thing, done: 12ff930

@huseyinbabal
Copy link
Owner

@ldziedziul do not forget to fix PR check failure

@huseyinbabal
Copy link
Owner

@ldziedziul Feel free to merge so that I can introduce another release candidate

@ldziedziul
Copy link
Contributor Author

ldziedziul commented Jan 16, 2026

I see no merge button :)
image

@huseyinbabal huseyinbabal merged commit 5306768 into huseyinbabal:master Jan 16, 2026
4 checks passed
@huseyinbabal
Copy link
Owner

Merged, thanks for you effor 🙏 a new version will be arrived soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to view the secret value

2 participants