-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add PHP 8.5 support for all build variants #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add PHP 8.5 to GitHub Actions workflow matrix - Update build.sh to include PHP 8.5 docker pulls and builds - Update clean.sh to remove PHP 8.5 images - Update README.md with PHP 8.5 as the latest version - Add comprehensive documentation of supported PHP versions and available tags - Move latest and latest-alpine tags from PHP 8.4 to PHP 8.5 All variants (apache-trixie, apache-bookworm, fpm-alpine) now support PHP 8.5
WalkthroughAdds PHP 8.5 support across CI, documentation, build and cleanup scripts, and updates three Dockerfiles to parse PHP version and skip installing the opcache extension for PHP 8.5+. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/docker-buildx.yml(3 hunks)README.md(3 hunks)build.sh(1 hunks)clean.sh(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
- GitHub Check: buildx (8.5, fpm-alpine)
- GitHub Check: buildx (8.5, apache-bookworm)
- GitHub Check: buildx (8.3, apache-bookworm)
- GitHub Check: buildx (8.5, apache-trixie)
- GitHub Check: buildx (8.4, apache-trixie)
- GitHub Check: buildx (8.4, fpm-alpine)
- GitHub Check: buildx (8.3, fpm-alpine)
- GitHub Check: buildx (8.1, apache-bookworm)
- GitHub Check: buildx (8.4, apache-bookworm)
- GitHub Check: buildx (8.2, apache-bookworm)
- GitHub Check: buildx (8.2, apache-trixie)
- GitHub Check: buildx (8.1, apache-trixie)
- GitHub Check: buildx (8.1, fpm-alpine)
- GitHub Check: buildx (8.2, fpm-alpine)
🔇 Additional comments (9)
clean.sh (1)
7-7: LGTM!PHP 8.5 cleanup additions follow the established pattern and align with the new images built in build.sh.
Also applies to: 12-12, 19-19, 24-24
.github/workflows/docker-buildx.yml (3)
19-19: LGTM!PHP 8.5 added to the version matrix. The workflow will now build all three variants for five PHP versions.
43-43: LGTM!Conditional correctly includes PHP 8.5 in the DOCKERFILE_DIR check.
62-62: LGTM!Latest tag logic correctly migrated from PHP 8.4 to 8.5 on the apache-trixie variant, aligning with the PR objective.
build.sh (3)
13-13: LGTM!PHP 8.5 base image pulls added for both apache-bookworm and fpm-alpine variants.
Also applies to: 18-18
26-26: LGTM!PHP 8.4 apache-bookworm build correctly configured with matching PHP_VERSION argument and Dockerfile path.
31-31: LGTM!PHP 8.4 and 8.5 Alpine builds correctly configured. The
latest-alpinetag is properly added to the 8.5-alpine build.Also applies to: 32-32
README.md (2)
14-36: LGTM!New "Supported PHP Versions" and "Available Tags" sections are well-structured and comprehensive. Documentation clearly lists all five PHP versions (8.1–8.5) and their available tags with architecture support. The distinction between Apache and Alpine variants is clear.
48-48: LGTM!Usage examples updated consistently to reference PHP 8.5 as the current version for both Apache and FPM-Alpine variants.
Also applies to: 65-65
Opcache extension is now bundled by default in PHP 8.5+, causing installation errors when attempting to install it via docker-php-ext-install. This change extracts the PHP version from the PHP_VERSION build argument and uses a case statement to conditionally include opcache only for PHP versions below 8.5.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
This PR adds PHP 8.5 support to all Docker image variants.
Changes
All variants (apache-trixie, apache-bookworm, fpm-alpine) now support PHP 8.5.
Testing
The GitHub Actions workflow will build and push images for all PHP versions including 8.5 upon merge.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.