Conversation
huyfififi
force-pushed
the
leetcode-56-merge-intervals
branch
from
7d32984 to
dd7f2e7
Compare
oda
reviewed
Jan 26, 2026
| それでも完全にしっくりと意味と名前を対応させられている感じはなんだかしないのだが。 | ||
| Step 1 は説明的であることを心がけたが、読まなければいけない行数が多いので逆に読みにくいかもしれない。 | ||
|
|
||
| `std::vector<std::vector<int>> sorted_intervals(intervals);`の時点では厳密にはソートされていないので名前とのチグハグ感があるが、他に良い案も思いつかなかった。ソートするまでの処理と、続く処理の間に一行空行を挟んでいるので誤解はないと思うが。 |
| } | ||
| } | ||
|
|
||
| merged_intervals.push_back(last_interval); |
There was a problem hiding this comment.
これを不要とするために last_interval の代わりに、merged_intervals.last() で代用する手はあるんですが、こっちのほうがいいかもしれませんね。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/merge-intervals/