Fix layout inference for column-vector tensor views#191
Merged
zhangstevenunity merged 2 commits intoMar 4, 2026
Merged
Conversation
Make the explicit-DN layout sample use a DN-consistent stride pattern so InferPTOLayout verification passes when enabled by default.
KurrinQu
pushed a commit
to KurrinQu/PTOAS
that referenced
this pull request
Apr 25, 2026
KurrinQu
pushed a commit
to KurrinQu/PTOAS
that referenced
this pull request
Apr 28, 2026
Zhendong404
pushed a commit
to Zhendong404/PTOAS
that referenced
this pull request
May 1, 2026
FangRui0
pushed a commit
to FangRui0/PTOAS
that referenced
this pull request
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #190.
What was wrong
For some 2D tensor views (e.g. shape
(16 x 1)with contiguous strides(1, 1)), the emittedGlobalTensor<...>layout parameter could be inferred asNDeven though the expected layout isDN(column-vector).What this PR changes
1) to match the GlobalTensor ABI.1), prefer:DNfor(rows x 1)NDfor(1 x cols)layoutattribute inferred/propagated in IR, instead of re-inferring layout in multiple places.--disable-infer-layout).Tests
test/samples/Layout/tensor_view_infer_layout_dn.py+ guard intest/samples/runop.sh.