test: add qwen3 decode A3/A5 PTO cases#491
Draft
HecreReed wants to merge 3 commits intohw-native-sys:mainfrom
Draft
test: add qwen3 decode A3/A5 PTO cases#491HecreReed wants to merge 3 commits intohw-native-sys:mainfrom
HecreReed wants to merge 3 commits intohw-native-sys:mainfrom
Conversation
Collaborator
Author
|
/run a3 qwen3_decode_incore_0 qwen3_decode_incore_1 qwen3_decode_incore_2 qwen3_decode_incore_3 qwen3_decode_incore_4 qwen3_decode_incore_5 qwen3_decode_incore_6 qwen3_decode_incore_7 qwen3_decode_incore_8 qwen3_decode_incore_9 qwen3_decode_incore_10 qwen3_decode_incore_11 qwen3_decode_incore_12 qwen3_decode_incore_13 qwen3_decode_incore_14 qwen3_decode_incore_15 qwen3_decode_incore_16 |
Collaborator
Author
|
/run a5 qwen3_decode_incore_0 qwen3_decode_incore_1 qwen3_decode_incore_2 qwen3_decode_incore_3 qwen3_decode_incore_4 qwen3_decode_incore_5 qwen3_decode_incore_6 qwen3_decode_incore_7 qwen3_decode_incore_8 qwen3_decode_incore_9 qwen3_decode_incore_10 qwen3_decode_incore_11 qwen3_decode_incore_12 qwen3_decode_incore_13 qwen3_decode_incore_14 qwen3_decode_incore_15 qwen3_decode_incore_16 --pto-level=level3 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for Qwen3 decode kernels for A3 and A5 architectures by adding the necessary test case generation logic and PTO kernel fragments. The changes include updates to the test case generation script, the addition of new sample directories, and modifications to the runop.sh script to handle these new targets. My feedback suggests moving the growing configuration dictionary in the generation script to an external file for better maintainability and verifying the glob pattern in the shell script to avoid potential redundant file processing.
Comment on lines
+96
to
+142
| "qwen3_decode_incore_4": { | ||
| "v11": 1, | ||
| "v12": 0, | ||
| "v13": 1, | ||
| }, | ||
| "qwen3_decode_incore_5": { | ||
| "v4": 1, | ||
| "v5": 1, | ||
| "v6": 1, | ||
| "v7": 0, | ||
| }, | ||
| "qwen3_decode_incore_6": { | ||
| "v5": 1, | ||
| "v6": 1, | ||
| "v7": 0, | ||
| }, | ||
| "qwen3_decode_incore_7": { | ||
| "v4": 1, | ||
| "v5": 1, | ||
| "v6": 1, | ||
| "v7": 0, | ||
| }, | ||
| "qwen3_decode_incore_8": { | ||
| "v5": 2, | ||
| "v6": 1, | ||
| }, | ||
| "qwen3_decode_incore_9": { | ||
| "v4": 1, | ||
| "v5": 64, | ||
| }, | ||
| "qwen3_decode_incore_10": { | ||
| "v4": 1, | ||
| "v5": 64, | ||
| }, | ||
| "qwen3_decode_incore_12": { | ||
| "v4": 256, | ||
| }, | ||
| "qwen3_decode_incore_13": { | ||
| "v4": 256, | ||
| }, | ||
| "qwen3_decode_incore_15": { | ||
| "v4": 128, | ||
| }, | ||
| "qwen3_decode_incore_16": { | ||
| "v4": 1, | ||
| "v5": 128, | ||
| }, |
There was a problem hiding this comment.
The dictionary CASE_POINTER_COUNT_MINIMUMS is growing large. Consider moving these configuration values to a separate JSON or YAML file to improve maintainability and keep the script clean.
| fi | ||
|
|
||
| for asset in "${sample_dir}"/*_golden.py "${sample_dir}"/*_compare.py; do | ||
| for asset in "${sample_dir}"/*_golden.py "${sample_dir}"/*_compare.py "${sample_dir}"/*_golden_*.py; do |
There was a problem hiding this comment.
The glob pattern "${sample_dir}"/*_golden_*.py might be redundant if *_golden.py already covers the necessary files. Ensure this does not lead to double-processing or unexpected file inclusion.
Codex Review该评论由 review 机器人自动更新。
SummaryReview failed at stage Findings未生成结构化 findings，因为 review 过程提前失败。 Log Tail |
A3 板测成功
|
A5 板测成功
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
qwen3_decode_incore_*.ptofragments regenerated frompypto-lib/examples/models/qwen3/qwen3_32b_decode.pyrunop.shandgenerate_testcase.pyso these direct.ptosamples use the right default flags and golden assetsValidation
python3 -m py_compile test/npu_validation/scripts/generate_testcase.py test/samples/Qwen3DecodeA3/qwen3_decode_golden_lib.py test/samples/Qwen3DecodeA5/qwen3_decode_golden_lib.py test/samples/Qwen3DecodeA3/*_golden.py test/samples/Qwen3DecodeA5/*_golden.pybash -n test/samples/runop.shptoas -> generate_testcase -> custom golden