Skip to content

Drain MTE before tnotify#712

Draft
zhangstevenunity wants to merge 1 commit into
mainfrom
codex/issue711-tnotify-mte-drain
Draft

Drain MTE before tnotify#712
zhangstevenunity wants to merge 1 commit into
mainfrom
codex/issue711-tnotify-mte-drain

Conversation

@zhangstevenunity
Copy link
Copy Markdown
Collaborator

Summary

  • Insert pipe_barrier(PIPE_ALL) before lowering pto.comm.tnotify to pto::comm::TNOTIFY.
  • Add a lit regression covering tload/tstore followed by tnotify.
  • Document the tnotify lowering guarantee.

Fixes #711

Tests

  • ninja -C build-main-wsl tools/ptoas/ptoas
  • build-main-wsl/tools/ptoas/ptoas --pto-arch=a3 test/lit/pto/issue711_tnotify_mte_drain.pto -o - 2>&1 | FileCheck test/lit/pto/issue711_tnotify_mte_drain.pto
  • build-main-wsl/tools/ptoas/ptoas --pto-arch=a3 test/lit/pto/comm_p2p_emitc.pto -o - 2>&1 | FileCheck test/lit/pto/comm_p2p_emitc.pto --check-prefix=A3

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request ensures that pto.comm.tnotify lowering emits a pipe_barrier(PIPE_ALL) before calling pto::comm::TNOTIFY to drain prior MTE-side loads and stores. This change is implemented in PTOToEmitC.cpp, documented in PTO_IR_manual.md, and verified with a new LIT test. I have no feedback to provide as there are no review comments.

@reedhecre
Copy link
Copy Markdown

reedhecre commented May 27, 2026

Codex Review

该评论由 review 机器人自动更新。

  • PR: Drain MTE before tnotify #712 Drain MTE before tnotify
  • Author: zhangstevenunity
  • Base/Head: main / codex/issue711-tnotify-mte-drain
  • Head SHA: 331e0c4227b7
  • Trigger: 检测到新的 open PR
  • Generated At: 2026-05-27T10:16:08Z
  • Status: completed

Summary

未检查到 PR #712 存在问题

Findings

No issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] No pipe sync inserted between MTE-pipe ops (pto.tstore / pto.tload, local or remote) and pto.comm.tnotify — signal can overtake in-flight data

2 participants