Fix: clear cmake cache when git HEAD is unavailable#865
Merged
ChaoWao merged 1 commit intoMay 27, 2026
Merged
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
_invalidate_cache_if_stale previously returned early when git rev-parse could not produce a commit (no .git, transient subprocess failure), leaving any old marker and build artifacts in place. That silently defeats the invalidation guard whenever git is briefly unreachable. Treat an unavailable HEAD as definitely-stale: wipe the cache dir and do not write a marker, so the next build also rebuilds from scratch. A clean compile is cheap relative to the risk of linking against mismatched objects.
ChaoWao
force-pushed
the
fix/treat-missing-git-head-as-stale-cache
branch
from
0114264 to
2bb1682
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_invalidate_cache_if_staleused to silently skip invalidation whengit rev-parse HEADreturned nothing (no.git, transient subprocess failure), leaving stale objects inbuild/cache/.tests/ut/py/test_runtime_builder.py::TestInvalidateCacheIfStalecovering all three branches (match / mismatch / unavailable).Testing
python -m pytest tests/ut/py/test_runtime_builder.py— 21 passed, 4 hardware-skipped