-
Notifications
You must be signed in to change notification settings - Fork 0
chore: updated personal works pages #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request makes updates to the API server fixtures within the works.json5 file. It removes the "www" subdomain from the "waseda-mochida" entry URL and adds a new entry for "mosaiqued" that contains its title, URL, description, and a list of tech stacks. Changes
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
api-server/fixtures/payloads/works.json5 (1)
65-65: Consider using a custom domain for the Cloud Run service.The URL contains a project number (1037550336239) which could be considered sensitive information. Consider using a custom domain instead.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
api-server/fixtures/payloads/works.json5(2 hunks)
🔇 Additional comments (3)
api-server/fixtures/payloads/works.json5 (3)
66-66: Consider adding the GitHub repository URL if the project is open source.The GitHub repository URL is empty. If this is an open-source project, adding the repository URL would help users explore the implementation details.
63-75: LGTM on the new project entry!The new mosaiqued project entry is well-structured with appropriate tech stack for a mosaic art generator. The JSON5 format is maintained correctly.
42-42: Verify the updated domain is accessible.The URL change from www.waseda-mochida.com to waseda-mochida.com aligns with the CloudFlare migration mentioned in the PR objectives.
✅ Verification successful
🏁 Script executed:
#!/bin/bash # Check if the new domain is accessible and properly redirected curl -I -L https://waseda-mochida.comLength of output: 1025
Domain accessibility confirmed.
The updated URL "https://waseda-mochida.com" returns an HTTP/2 200 response, confirming that the domain update is working as intended for the CloudFlare migration.
Issue/PR link
N/A
What does this PR do?
Describe what changes you make in your branch:
(Optional) Additional Contexts
Describe additional information for reviewers (i.e. What does not included)
mainto confirm changes would be appliedSummary by CodeRabbit
New Features
Updates