Skip to content

Codex/effect srp refactor#18

Merged
hwisu merged 30 commits intomainfrom
codex/effect-srp-refactor
Mar 10, 2026
Merged

Codex/effect srp refactor#18
hwisu merged 30 commits intomainfrom
codex/effect-srp-refactor

Conversation

@hwisu
Copy link
Copy Markdown
Owner

@hwisu hwisu commented Mar 9, 2026

No description provided.

hwisu added 23 commits March 6, 2026 15:12
@hwisu
refactor effect boundaries for ui and runtime entrypoints
0b6ee41
@hwisu
extract shell and settings ui models
84eb392
@hwisu
adopt rust 2024 workspace defaults
f885cb7
@hwisu
document unsafe boundaries in rust tooling
6fb22d6
@hwisu
pin rust toolchain across local and ci
3f0ed8b
@hwisu
refactor effect boundaries and rust entrypoints
fe6baa7
@hwisu
split desktop change reader and worker auth routes
4ddb4a5
@hwisu
split handoff modules and desktop artifact commands
647b7eb
@hwisu
extract setup doctor helpers
f7ca30a
@hwisu
extract desktop vector and summary modules
21a681d
@hwisu
extract desktop session access module
dba83dc
@hwisu
extract desktop runtime settings module
eaeac87
@hwisu
split desktop main tests and lifecycle status
fc49067
@hwisu
split desktop main tests by concern
35c7fab
@hwisu
refactor(core): extract local store adapter
cc9c385
@hwisu
refactor(parsers): make ParserRegistry the main entrypoint
45103ec
@hwisu
refactor(summary): split git collection helpers
8230c10
@hwisu
test(cli): split handoff CLI integration coverage
5784a96
@hwisu
feat(ui): add settings page panel components
b6a7ab6
@hwisu
refactor(rust): align runtime boundaries with 2026 practices
0d9210e
@hwisu
chore(platform): drop generated desktop and worker artifacts
9101576
@hwisu
Add Korean localization and build cache guardrails
688f619
@hwisu
Disable daemon doctests
5297b09
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 9, 2026 •
edited
Loading

OpenSession Review

Metric Value
Ledger ref refs/opensession/branches/Y29kZXgvZWZmZWN0LXNycC1yZWZhY3Rvcg
Base -> Head bf7d505805dd45cc54dd2e064757fbab2dec2bd2 -> 081e7be88778397672ce68447ae846c936239439
Updated at (UTC) 2026-03-09T11:27:10.359Z
Commit range size 30
Primary linked sessions 10
Modified files 341
Added/updated test files 36
Session scope primary only (auxiliary filtered)
Quick links Files changed · Commits · Compare
Local review Open in UI · ops review https://github.com/hwisu/opensession/pull/18
Artifact branch opensession/pr-18-sessions · manifest.json
Ledger status available

Reviewer Quick Digest

Q&A Areas Files Tests Sessions / Commit
4 9 341 36 0.3

Area Summary

Area Files changed
crates 221
packages 61
desktop 24
(root) 11
scripts 8
web 8
.github 6
.githooks 1

Interactive Q&A

Session Commit Question Answer
019cc1a4-9605-78d3-8026-0fef97395e92 b6a7ab6 - migration_scope (범위): 이번 계획의 1차 범위를 어디까지로 잡을까요? - effect_adoption_style (도입강도): Effect는 어디까지 밀어 넣는 방향을 원하시나요? effect_adoption_style: Boundary Bridge (Recommended) migration_scope: 그래. 그리고 Rust도 근본적으로 이펙트 기반으로 재구성할수 있잔슴
019cc1a4-9605-78d3-8026-0fef97395e92 b6a7ab6 - scope (범위): 이번 리팩토링 계획의 1차 범위를 어디까지 잡을까요? - priority (우선순위): 어떤 기준으로 tranche 순서를 잡을까요? priority: 라인이 엄청 길어도 단일 책임이면 괜찮음. '책임' 관점 scope: Rust 는 천줄로 잡고, 테스트나 스벨트도 적절한 기준을 세우서 해줘.
019cd04e-9d60-7451-9a3c-0df5c91dda17 33296b8 - improvement_priority (우선순위): 이번 개선 계획은 어떤 축을 최우선으로 최적화할까요? - compatibility_posture (안정성): 계획은 어느 정도의 호환성/리스크를 전제로 짤까요? compatibility_posture: 호환성 낮게 improvement_priority: 구조 정리 (Recommended)
019cd04e-9d60-7451-9a3c-0df5c91dda17 33296b8 - refactor_scope (범위): 이 계획의 적용 범위를 어떻게 잡을까요? - msrv_strategy (MSRV): Rust 최신 기준 반영은 어떻게 다룰까요? msrv_strategy: 1.93 유지 (Recommended) refactor_scope: 핵심부터 (Recommended)
Changed paths (341)
  • .githooks/pre-commit
  • .github/workflows/ci-deep.yml
  • .github/workflows/ci.yml
  • .github/workflows/deploy.yml
  • .github/workflows/desktop-dryrun.yml
  • .github/workflows/publish.yml
  • .github/workflows/session-review.yml
  • .gitignore
  • CONTRIBUTING.md
  • Cargo.lock
  • Cargo.toml
  • README.ko.md
  • ...and 329 more
Added/updated tests (36)
  • crates/cli/tests/handoff_cli.rs
  • crates/cli/tests/handoff_cli/cleanup_cli.rs
  • crates/cli/tests/handoff_cli/handoff_cases.rs
  • crates/cli/tests/handoff_cli/help_cli.rs
  • crates/cli/tests/handoff_cli/inspect_cli.rs
  • crates/cli/tests/handoff_cli/parse_cli.rs
  • crates/cli/tests/handoff_cli/review_cli.rs
  • crates/cli/tests/handoff_cli/setup_cli.rs
  • crates/cli/tests/handoff_cli/share_cli.rs
  • crates/cli/tests/handoff_cli/view_cli.rs
  • crates/e2e/tests/common.rs
  • crates/e2e/tests/environment.rs
  • ...and 24 more
Commit trail (30)
Linked sessions (10)
Session ID Tool Files Commits Open OpenSession JSONL Meta Title
019cd107-d57d-7871-9f34-3a9e0044973e codex 50 5297b09, 688f619 open web jsonl meta 한국어 지원 및 플랫폼 언어 따라가는 것 계획해줘.
019cc1a4-9605-78d3-8026-0fef97395e92 codex 47 b6a7ab6, 35c7fab, fc49067 +12 open web jsonl meta 코드 전체를 Effect Monad를 기준으로 잘 정렬되도록 코드를 다듬어줘. Testable Code를 목표로 적절하게 레이러를 분리하기...
019cd1fd-7baa-7b81-802f-137782dbf422 codex 27 081e7be, db033dd, 49ceb94 +4 open web jsonl meta OpenSession Review Ledger ref: refs/opensession/branches/Y29kZXgvZWZmZWN0LXNy...
019cd04e-9d60-7451-9a3c-0df5c91dda17 codex 21 33296b8, 3477e10, 901a74b +9 open web jsonl meta Effect 기준으로 러스트 코드가 정렬되었는지 확인해줘. 목표는 - 2026년 최신기준으로 러스트 코드를 깔끔하게 만들기
019cc0d7-8481-7271-8314-175963aba95a codex 17 eaeac87, dba83dc, 21a681d +4 open web jsonl meta Rebuilding vector index Session embeddings are being rebuilt in background. ...
019cd105-c74a-7443-a529-49324bffb675 codex 3 081e7be, 33296b8, 3477e10 +3 open web jsonl meta warning: unused import: require_non_empty_request_field --> src/main.rs:7:...
019cd173-122c-7d52-a1f1-90a39c70d89d codex 2 081e7be, 33296b8, 3477e10 +3 open web jsonl meta 여기폴더가 130기가나 되는데 뭔가 문제가 있는것 같아 기존 아티팩트가 다 남아잇나 ?
019cc1f7-772b-7513-8bd9-83ffca7220f6 codex 0 35c7fab, fc49067, eaeac87 +7 open web jsonl meta 현재의 바이너리를 바탕으로, 필요한 노력을 카운트 하지 않고 이런 컨셉의 어플리케이션이 go 인게 좋을까? 아니면 러스트인게 좋을까? ...
019cd1f7-de3d-74c2-8bd2-f82ecbaba2c6 codex 0 081e7be, 33296b8, 3477e10 +1 open web jsonl meta 변경사항 커밋/푸시해줘
019cd212-d93a-7bd1-8c3d-d29761446add codex 0 081e7be, 33296b8, 3477e10 +1 open web jsonl meta 또 패키지가 너무 크기 않은지, 직접 구현해도 되는데 쓸데없이 패키지 쓴게 없는지 검토해줘.

@hwisu hwisu mentioned this pull request Mar 9, 2026
Closed
This was referenced Mar 9, 2026
Closed
Closed
@hwisu hwisu merged commit ddf5123 into main Mar 10, 2026
9 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 10, 2026

OpenSession Review (final snapshot)

Metric Value
Ledger ref refs/opensession/branches/Y29kZXgvZWZmZWN0LXNycC1yZWZhY3Rvcg
Base -> Head bf7d505805dd45cc54dd2e064757fbab2dec2bd2 -> 081e7be88778397672ce68447ae846c936239439
Updated at (UTC) 2026-03-10T02:15:30.132Z
Commit range size 30
Primary linked sessions 10
Modified files 341
Added/updated test files 36
Session scope primary only (auxiliary filtered)
Quick links Files changed · Commits · Compare
Local review Open in UI · ops review https://github.com/hwisu/opensession/pull/18
Ledger status available

Reviewer Quick Digest

Q&A Areas Files Tests Sessions / Commit
4 9 341 36 0.3

Area Summary

Area Files changed
crates 221
packages 61
desktop 24
(root) 11
scripts 8
web 8
.github 6
.githooks 1

Interactive Q&A

Session Commit Question Answer
019cc1a4-9605-78d3-8026-0fef97395e92 b6a7ab6 - migration_scope (범위): 이번 계획의 1차 범위를 어디까지로 잡을까요? - effect_adoption_style (도입강도): Effect는 어디까지 밀어 넣는 방향을 원하시나요? effect_adoption_style: Boundary Bridge (Recommended) migration_scope: 그래. 그리고 Rust도 근본적으로 이펙트 기반으로 재구성할수 있잔슴
019cc1a4-9605-78d3-8026-0fef97395e92 b6a7ab6 - scope (범위): 이번 리팩토링 계획의 1차 범위를 어디까지 잡을까요? - priority (우선순위): 어떤 기준으로 tranche 순서를 잡을까요? priority: 라인이 엄청 길어도 단일 책임이면 괜찮음. '책임' 관점 scope: Rust 는 천줄로 잡고, 테스트나 스벨트도 적절한 기준을 세우서 해줘.
019cd04e-9d60-7451-9a3c-0df5c91dda17 33296b8 - improvement_priority (우선순위): 이번 개선 계획은 어떤 축을 최우선으로 최적화할까요? - compatibility_posture (안정성): 계획은 어느 정도의 호환성/리스크를 전제로 짤까요? compatibility_posture: 호환성 낮게 improvement_priority: 구조 정리 (Recommended)
019cd04e-9d60-7451-9a3c-0df5c91dda17 33296b8 - refactor_scope (범위): 이 계획의 적용 범위를 어떻게 잡을까요? - msrv_strategy (MSRV): Rust 최신 기준 반영은 어떻게 다룰까요? msrv_strategy: 1.93 유지 (Recommended) refactor_scope: 핵심부터 (Recommended)
Changed paths (341)
  • .githooks/pre-commit
  • .github/workflows/ci-deep.yml
  • .github/workflows/ci.yml
  • .github/workflows/deploy.yml
  • .github/workflows/desktop-dryrun.yml
  • .github/workflows/publish.yml
  • .github/workflows/session-review.yml
  • .gitignore
  • CONTRIBUTING.md
  • Cargo.lock
  • Cargo.toml
  • README.ko.md
  • ...and 329 more
Added/updated tests (36)
  • crates/cli/tests/handoff_cli.rs
  • crates/cli/tests/handoff_cli/cleanup_cli.rs
  • crates/cli/tests/handoff_cli/handoff_cases.rs
  • crates/cli/tests/handoff_cli/help_cli.rs
  • crates/cli/tests/handoff_cli/inspect_cli.rs
  • crates/cli/tests/handoff_cli/parse_cli.rs
  • crates/cli/tests/handoff_cli/review_cli.rs
  • crates/cli/tests/handoff_cli/setup_cli.rs
  • crates/cli/tests/handoff_cli/share_cli.rs
  • crates/cli/tests/handoff_cli/view_cli.rs
  • crates/e2e/tests/common.rs
  • crates/e2e/tests/environment.rs
  • ...and 24 more
Commit trail (30)
Linked sessions (10)
Session ID Tool Files Commits Open OpenSession JSONL Meta Title
019cd107-d57d-7871-9f34-3a9e0044973e codex 50 5297b09, 688f619 open - - v1/01/019cd107-d57d-7871-9f34-3a9e0044973e.meta.json 한국어 지원 및 플랫폼 언어 따라가는 것 계획해줘.
019cc1a4-9605-78d3-8026-0fef97395e92 codex 47 b6a7ab6, 35c7fab, fc49067 +12 open - - v1/01/019cc1a4-9605-78d3-8026-0fef97395e92.meta.json 코드 전체를 Effect Monad를 기준으로 잘 정렬되도록 코드를 다듬어줘. Testable Code를 목표로 적절하게 레이러를 분리하기...
019cd1fd-7baa-7b81-802f-137782dbf422 codex 27 081e7be, db033dd, 49ceb94 +4 open - - v1/01/019cd1fd-7baa-7b81-802f-137782dbf422.meta.json OpenSession Review Ledger ref: refs/opensession/branches/Y29kZXgvZWZmZWN0LXNy...
019cd04e-9d60-7451-9a3c-0df5c91dda17 codex 21 33296b8, 3477e10, 901a74b +9 open - - v1/01/019cd04e-9d60-7451-9a3c-0df5c91dda17.meta.json Effect 기준으로 러스트 코드가 정렬되었는지 확인해줘. 목표는 - 2026년 최신기준으로 러스트 코드를 깔끔하게 만들기
019cc0d7-8481-7271-8314-175963aba95a codex 17 eaeac87, dba83dc, 21a681d +4 open - - v1/01/019cc0d7-8481-7271-8314-175963aba95a.meta.json Rebuilding vector index Session embeddings are being rebuilt in background. ...
019cd105-c74a-7443-a529-49324bffb675 codex 3 081e7be, 33296b8, 3477e10 +3 open - - v1/01/019cd105-c74a-7443-a529-49324bffb675.meta.json warning: unused import: require_non_empty_request_field --> src/main.rs:7:...
019cd173-122c-7d52-a1f1-90a39c70d89d codex 2 081e7be, 33296b8, 3477e10 +3 open - - v1/01/019cd173-122c-7d52-a1f1-90a39c70d89d.meta.json 여기폴더가 130기가나 되는데 뭔가 문제가 있는것 같아 기존 아티팩트가 다 남아잇나 ?
019cc1f7-772b-7513-8bd9-83ffca7220f6 codex 0 35c7fab, fc49067, eaeac87 +7 open - - v1/01/019cc1f7-772b-7513-8bd9-83ffca7220f6.meta.json 현재의 바이너리를 바탕으로, 필요한 노력을 카운트 하지 않고 이런 컨셉의 어플리케이션이 go 인게 좋을까? 아니면 러스트인게 좋을까? ...
019cd1f7-de3d-74c2-8bd2-f82ecbaba2c6 codex 0 081e7be, 33296b8, 3477e10 +1 open - - v1/01/019cd1f7-de3d-74c2-8bd2-f82ecbaba2c6.meta.json 변경사항 커밋/푸시해줘
019cd212-d93a-7bd1-8c3d-d29761446add codex 0 081e7be, 33296b8, 3477e10 +1 open - - v1/01/019cd212-d93a-7bd1-8c3d-d29761446add.meta.json 또 패키지가 너무 크기 않은지, 직접 구현해도 되는데 쓸데없이 패키지 쓴게 없는지 검토해줘.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hwisu