Skip to content

Conversation

@Attakay78
Copy link
Contributor

@Attakay78 Attakay78 commented May 18, 2025

Why this PR:

  • This PR adds supports for Inertia.js DeferredProp feature in the version 2 update. This allows data to be deferred and loaded later via a subsequent request after user initiated request.
  • Adds supports for partial reloads to be asynchronous as supported by inertia.js version 2.

@Attakay78 Attakay78 changed the title Feat: Introduce Inertia version 2 DeferredProp feature #35 Feat: Introduce Inertia version 2 DeferredProp feature May 18, 2025
@Attakay78
Copy link
Contributor Author

@hxjo I have raised a WIP RP which works, I will resolve the failing tests and type check later.

Would you like us to update the existing vue backend and frontend example with the version 2 changes or have a dedicated example for that?

Also I have added async support for partial loading.

@Attakay78 Attakay78 force-pushed the main branch 2 times, most recently from ed6b036 to 8871cf4 Compare May 19, 2025 02:35
@hxjo
Copy link
Owner

hxjo commented May 19, 2025

@Attakay78 a few points:

  1. For now, please add docstrings on new functions, new utils that those are internal only.
  2. Do not bump the version of the package with a major. Given all required changes to support inertia 2 have not been implemented, there's no point in exposing those for now.
  3. For now, please add the examples in a subfolder indeed, as those are not to be used for now

Thanks for the work !!

@Attakay78 Attakay78 force-pushed the main branch 2 times, most recently from 39dbf46 to bbe9c49 Compare May 19, 2025 17:23
@Attakay78 Attakay78 marked this pull request as ready for review May 19, 2025 17:26
@Attakay78
Copy link
Contributor Author

@hxjo Can you review the implementations so far.

@Attakay78
Copy link
Contributor Author

@hxjo Comments addressed

@hxjo
Copy link
Owner

hxjo commented May 20, 2025

@Attakay78 could you keep the git history, rather than force-pushing and erasing the log of changes ?
That makes it hard to follow the chain of thoughts. It's also very unpractical for reviews.
I'll take another look at the PR on my lunch break and I'll probably approve and merge it

@Attakay78
Copy link
Contributor Author

@hxjo Noted, normally do that when I don't want to have too many commits on one PR. Going forward, I will push a new commit for major or important changes and still do the force for trivial issues to prevent too many commits.

@Attakay78
Copy link
Contributor Author

@hxjo Can we get this done. Working on the second feature.

@hxjo hxjo merged commit 267d6a7 into hxjo:main May 25, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants