-
Notifications
You must be signed in to change notification settings - Fork 10
Feat: Introduce Inertia version 2 DeferredProp feature #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@hxjo I have raised a WIP RP which works, I will resolve the failing tests and type check later. Would you like us to update the existing vue backend and frontend example with the version 2 changes or have a dedicated example for that? Also I have added async support for partial loading. |
ed6b036 to
8871cf4
Compare
|
@Attakay78 a few points:
Thanks for the work !! |
39dbf46 to
bbe9c49
Compare
|
@hxjo Can you review the implementations so far. |
|
@hxjo Comments addressed |
|
@Attakay78 could you keep the git history, rather than force-pushing and erasing the log of changes ? |
|
@hxjo Noted, normally do that when I don't want to have too many commits on one PR. Going forward, I will push a new commit for major or important changes and still do the force for trivial issues to prevent too many commits. |
|
@hxjo Can we get this done. Working on the second feature. |
Why this PR: