Added events to the MCP and Robot #3
Conversation
lorenwest
commented
Dec 11, 2014
lorenwest
commented
- Added "events" attribute to the MCP, Robot, and Device
- Added event discovery endpoints to match command discovery endpoints
- Added event GET endpoints at the MCP and Robot level to match the GET endpoint at the Device
- Provided consistent API ordering at all 3 levels:
- Command discovery
- Event discovery
- Command POST
- Event GET
There was a problem hiding this comment.
At first I named this event "pinged" to reduce command/event name confusion, but changed it to "ping" because that's the name of the event in implementations.
There was a problem hiding this comment.
It appears in cylon.js the command execution pattern is to issue events for results vs. calling callbacks, which is probably why ping is both a command and an event. MCP implementations could choose to auto-expose these command events in the events array, or require them to be explicitly defined.
|
@stewart @zankich & @edgarsilva any comments? |
|
Sorry, I meant to merge this already. Thanks for the contribution! |
Added events to the MCP and Robot
|
Would you like help implementing? I'm working with cylon and wouldn't mind adding this support. |
|
I think @stewart has already been doing some work on it, and will probably commit something next week. Once he has his commits in place, you can perhaps provide some feedback or additional implementation, how does that sound? |
|
Excellent. |
2 participants
