Skip to content

Update zh.yaml#989

Merged
undefined-moe merged 6 commits into
hydro-dev:masterfrom
HetmesAskalana:patch-2
Jun 22, 2025
Merged

Update zh.yaml#989
undefined-moe merged 6 commits into
hydro-dev:masterfrom
HetmesAskalana:patch-2

Conversation

@HetmesAskalana

@HetmesAskalana HetmesAskalana commented Jun 7, 2025

Copy link
Copy Markdown
Contributor

update some translation, fix moderator tag

Summary by CodeRabbit

  • New Features

    • Added new Simplified Chinese translations for password reset notifications.
  • Bug Fixes

    • Corrected placeholder formatting in a moderator-related message.
    • Updated the translation for "Lucky" to improve accuracy.

add page title of reset pw
Fix Moderator tag
@coderabbitai

coderabbitai Bot commented Jun 7, 2025

Copy link
Copy Markdown

Walkthrough

This change updates the Simplified Chinese localization file by correcting the formatting of a placeholder in an existing string, modifying the translation for "Lucky," and adding two new localization keys: "user_lostpass_mail_sent" and "user_lostpass_with_code" with their respective translations. No other functional or structural changes are included.

Suggested reviewers

  • pandadtdyy

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 033a5e1 and 534a438.

📒 Files selected for processing (1)
  • packages/ui-default/locales/zh.yaml (3 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/ui-default/locales/zh.yaml
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
packages/ui-default/locales/zh.yaml (4)

6-6: Align translation of 'moderator' with existing term
Earlier in this file 'Moderator' is rendered as 管理员, but here the translation uses 管理者之一. For consistency (and to match UI terminology), consider using 管理员 instead of 管理者.


1010-1010: Add missing punctuation and context
The translation '密码重置邮件已发送' omits the trailing full stop and the target ("到您的电子邮箱") found in similar entries. Consider updating to '密码重置邮件已发送到您的电子邮箱。' for clarity and consistency.


1012-1012: Clarify translation to include 'with code'
The key user_lostpass_with_code implies a password reset flow with a code, but '重置密码' may be too generic. You might want to translate it as '使用验证码重置密码' to preserve context.


1098-1098: Ensure proper quoting for key with colon
Keys containing spaces and punctuation (e.g. Your role:) should be quoted in YAML to avoid parsing issues. Please confirm this line is wrapped in quotes like:

'Your role:': '您的角色'
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4b12eb6 and 033a5e1.

📒 Files selected for processing (1)
  • packages/ui-default/locales/zh.yaml (4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: build
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
packages/ui-default/locales/zh.yaml (1)

544-544: Approve translation adjustment for 'Lucky'
The change from 手气不错 to 试试手气 aligns well with the intended UI label ("Try your luck") and fits established patterns.

@pandadtdyy

Copy link
Copy Markdown
Member

Do not edit it on web!

@CuteMurasame

Copy link
Copy Markdown
Contributor

手气不错真的要改吗,google 都是手气不错

@HetmesAskalana

Copy link
Copy Markdown
Contributor Author

手气不错真的要改吗,google 都是手气不错

我看他是随机抽题,就顺手给改了
手气不错更像是描述抽完后的偏主观的状态,感觉不是很能准确地描述这个功能?

@HetmesAskalana

Copy link
Copy Markdown
Contributor Author

Do not edit it on web!

Sorry, it won’t happen again.

@undefined-moe undefined-moe merged commit 240b299 into hydro-dev:master Jun 22, 2025
7 checks passed
@HetmesAskalana HetmesAskalana deleted the patch-2 branch June 22, 2025 16:18
@coderabbitai coderabbitai Bot mentioned this pull request Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants