fix tree detail height#62
Merged
Merged
Conversation
mmaelicke
commented
Apr 9, 2023
| <IonCard | ||
| style={{ | ||
| position: "absolute", | ||
| margin: "0px", |
Member
Author
There was a problem hiding this comment.
The card has a margin, that was screwing up on iPads due to different values in relation to current viewport size
| margin: "0px", | ||
| top: 60, | ||
| left: 12, | ||
| left: 20, |
Member
Author
There was a problem hiding this comment.
This is the absolute displacement of the Buttons above the details
| width: "400px", | ||
| height: "90%", | ||
| maxWidth: "80%", | ||
| height: "calc(100% - 60px - 20px)", |
Member
Author
There was a problem hiding this comment.
the height is now calculated for the current height minus the fixed offsets
| // width: "33vw", | ||
| width: "400px", | ||
| height: "90%", | ||
| maxWidth: "80%", |
Member
Author
There was a problem hiding this comment.
Makes the card slightly smaller on iPad to not overlay the position button on the map
Collaborator
Member
Author
Can you also try chrome or safari? On both, a iPad screen size works for me, or did you try an actual iPad? |
JesJehle
approved these changes
Apr 11, 2023
Collaborator
JesJehle
left a comment
There was a problem hiding this comment.
It's working now. No idea why ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

fixes #58
I tested for Desktop, Mobile and iPad Air (in Chrome) to fix the width of the Tree Detail card.
I am not sure, what exactly the problem is on mobile devices. I will add a commented review to explain my changes.