Fix-filter#76
Merged
Merged
Conversation
JesJehle
approved these changes
Apr 20, 2023
Collaborator
JesJehle
left a comment
JesJehle
left a comment
There was a problem hiding this comment.
Perfect! Black magic for me :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #71
@JesJehle, I tried a lot of different stuff, but noticed, that the range sliders are actually not disabled, but kind of deselected (compare to distance, which is actually deselected). This is really weird and I still don't get it.
If you add the
<RangeFilter />to the inventory-list, it works perfectly, all the time. Thus, it was the component life-cycle of the popover.I changed the popover to never dismiss the components, thus the range-filter is now always mounted. A few quick tests indicate, that this was the problem. Thus, the error was caused by constantly creating and dismissing the component. With developer-tools enabled, this process was slowed down and 'fixed' the issue.
So, I think it works now, but I am not 100% sure why.