The value of !set command support multi line#93
The value of !set command support multi line#93xiedeyantu wants to merge 3 commits intohydromatic:mainfrom
Conversation
|
@julianhyde Could you help me to have a look this pr? |
| String[] parts = line.split(" "); | ||
| String propertyName = parts[1]; | ||
| String valueString = parts[2]; | ||
| while (valueString.startsWith("\"") && !valueString.endsWith("\"")) { |
There was a problem hiding this comment.
Add a test with multiple lines and I'll believe you. :)
There was a problem hiding this comment.
I have modified the test cases and readme.
|
Can you add tests for more than 2 lines, and tests where some of the lines are empty, and tests where line contains Quidem comment syntax. Also update the documentation in README.md. |
|
@julianhyde I have modified the test cases and readme.Please have a look again thanks! |
|
Thanks for the PR! I have merged (with a few revisions). When you have successfully used these extensions in a Calcite PR (using 0.12-SNAPSHOT), let me know, and I will release Quidem version 0.12. |
OK, I will finish this task as soon as possible! |
|
@julianhyde I have tested it locally and it works. |
3 participants
No description provided.