Skip to content

chore: add benchmarks for absolutize on clean absolute, dirty absolute, and relative paths#33

Merged
hyf0 merged 1 commit intomainfrom
hyf_32842903844
Feb 23, 2026
Merged

chore: add benchmarks for absolutize on clean absolute, dirty absolute, and relative paths#33
hyf0 merged 1 commit intomainfrom
hyf_32842903844

Conversation

@hyf0
Copy link
Copy Markdown
Owner

@hyf0 hyf0 commented Feb 23, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 23, 2026 13:04
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 23, 2026

Merging this PR will not alter performance

✅ 24 untouched benchmarks
🆕 5 new benchmarks
⏩ 1 skipped benchmark1

Performance Changes

Benchmark BASE HEAD Efficiency
🆕 absolutize_dirty_absolute N/A 12.7 µs N/A
🆕 absolutize_already_clean_absolute N/A 24 µs N/A
🆕 absolutize_relative_paths N/A 15 µs N/A
🆕 absolutize_with_relative_paths N/A 12.1 µs N/A
🆕 absolutize_with_already_clean_absolute N/A 10.4 µs N/A

Comparing hyf_32842903844 (2c99d14) with main (28a3dd5)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive benchmarks for the absolutize function to measure performance across different path types: clean absolute paths (expected zero-allocation fast path), relative paths (always allocates), and dirty absolute paths requiring normalization (always allocates).

Changes:

  • Added two new fixture arrays (RELATIVE_CLEAN and DIRTY_ABSOLUTE) to support targeted benchmarking scenarios
  • Extended benchmark suite with five new benchmark functions covering absolutize and absolutize_with methods across different path types

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
benches/fixtures.rs Added RELATIVE_CLEAN and DIRTY_ABSOLUTE fixture arrays for benchmarking different path normalization scenarios
benches/absolutize.rs Added benchmark functions for clean absolute, relative, and dirty absolute paths to measure performance characteristics

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hyf0 hyf0 merged commit 5585dd3 into main Feb 23, 2026
8 of 9 checks passed
@github-actions github-actions bot mentioned this pull request Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants