Fix: Use wildcard origin for postMessage in sendReadyMessage#9
Merged
Conversation
Fixes the SyntaxError that occurred when wildcard patterns (e.g., http://localhost:*, https://*.hygraph.com) were used directly as targetOrigin in postMessage calls. Changes: - Modified sendReadyMessage to use "*" as targetOrigin instead of iterating through allowedOrigins patterns - Security is maintained through origin validation in isOriginAllowed() - Updated tests to reflect the new behavior - Added tests for wildcard origin pattern validation - Bumped version to 1.0.5 The postMessage API only accepts specific origins or "*", not pattern strings with wildcards. Using "*" for the initial ready message is safe because we validate all incoming messages against the wildcard patterns in allowedOrigins. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Version 1.0.4 introduced wildcard support for
allowedOrigins(e.g.,http://localhost:*,https://*.hygraph.com), but this caused a runtime error:The issue occurred because
sendReadyMessage()tried to use wildcard patterns directly as thetargetOriginparameter inpostMessage()calls. The browser'spostMessageAPI only accepts:http://localhost:3000)"*"to send to any originIt cannot accept pattern strings like
http://localhost:*.Solution
Modified
sendReadyMessage()inMessageBridge.tsto use"*"as the target origin instead of iterating through theallowedOriginspatterns.Security
Security is maintained because:
allowedOriginsare still used to validate incoming messages viaisOriginAllowed()initmessage), all subsequent messages use the specific validated originChanges
sendReadyMessage()to use"*"as targetOriginTesting
🤖 Generated with Claude Code