Skip to content

reject no-default-ignore outside filesystem mode#33

Merged
hyle merged 1 commit intomainfrom
restrict-no-default-ignore-to-filesystem-mode
Mar 17, 2026
Merged

reject no-default-ignore outside filesystem mode#33
hyle merged 1 commit intomainfrom
restrict-no-default-ignore-to-filesystem-mode

Conversation

@hyle
Copy link
Copy Markdown
Owner

@hyle hyle commented Mar 17, 2026

Summary

Make --no-default-ignore behave honestly by rejecting it outside filesystem selection.

Changes

  • Reject --no-default-ignore when used with:
    • --from-stdin
    • --staged
    • --unstaged
    • --diff
  • Add a dedicated CLI error message explaining that the flag only applies to filesystem selection
  • Update the README to state that constraint explicitly
  • Add CLI coverage for both stdin-backed and Git-backed misuse cases

Why

--no-default-ignore only affects the recursive/filesystem path. Before this change, the CLI accepted it in explicit non-filesystem modes as a silent no-op, which made the contract less trustworthy. Rejecting it is more consistent with the rest of fuori’s flag validation style.

Verification

  • Ran make test successfully

@hyle hyle self-assigned this Mar 17, 2026
@hyle hyle added bug Something isn't working enhancement New feature or request labels Mar 17, 2026
@hyle hyle merged commit ef63d54 into main Mar 17, 2026
@hyle hyle deleted the restrict-no-default-ignore-to-filesystem-mode branch March 17, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant