Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes two small robustness fixes in fuori.
The first tightens shebang-based language detection by parsing the interpreter token instead of relying on broad substring matches. That prevents scripts like fish or pwsh from being mislabeled as Bash, while preserving existing behavior for common cases such as #!/bin/sh and #!/usr/bin/env python3.
The second fixes the command execution helper by setting FD_CLOEXEC on the exec-error pipe. This prevents the write end from leaking into successfully exec’d child processes and makes run_command_capture behave more correctly as a reusable primitive.