Merged
Conversation
offbyone
force-pushed
the
aws-secrets-manager
branch
3 times, most recently
from
5b80bf4 to
df63f03
Compare
* moved some shared secrets code into secrets._utils * add moto/boto dependencies (the latter being optional)
offbyone
force-pushed
the
aws-secrets-manager
branch
from
df63f03 to
d1b5bb3
Compare
hynek
requested changes
May 9, 2021
Owner
hynek
left a comment
hynek
left a comment
There was a problem hiding this comment.
Some minor stuff. I mean I don't know jack about AWS so those parts I'll have to trust you. :)
| @@ -0,0 +1,101 @@ | |||
| # Copyright 2021 Chris Rose | |||
Owner
There was a problem hiding this comment.
This is unprecedented in the code base – is it really necessary or is it some template boilerplate?
Contributor
Author
There was a problem hiding this comment.
There's an equivalent with "Hynek" at the top of every other module; I was following suit.
Owner
There was a problem hiding this comment.
Hm, it's weird to have files with a different copyright holder but I shall tolerate your charming presence forevermore!
- reformat docstrings - link the AWS SecretsManager product page - explicitly name pytest fixtures to avoid accidental direct use
offbyone
force-pushed
the
aws-secrets-manager
branch
from
29a80c6 to
bc17192
Compare
hynek
approved these changes
May 17, 2021
| @@ -0,0 +1,101 @@ | |||
| # Copyright 2021 Chris Rose | |||
Owner
There was a problem hiding this comment.
Hm, it's weird to have files with a different copyright holder but I shall tolerate your charming presence forevermore!
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
This is just a friendly reminder about the most common mistakes. Please make sure that you tick all boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing left to do.
docs/api.rstby hand.versionadded,versionchanged, ordeprecateddirectives. Find the appropriate next version in our__init__.pyfile..rstfiles is written using semantic newlines.If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!