Skip to content
This repository was archived by the owner on May 7, 2023. It is now read-only.

Comments

Refactor color variables#499

Merged
hyochan merged 2 commits intomasterfrom
refactor/colors
Oct 8, 2021
Merged

Refactor color variables#499
hyochan merged 2 commits intomasterfrom
refactor/colors

Conversation

@hyochan
Copy link
Owner

@hyochan hyochan commented Oct 8, 2021

Specify project

Client

Description

Previous color variables are not well organized. Simplified color variables and applied them to components.

Related Issues

N/A

Tests

Update snapshots

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update snapshot.
  • I am willing to follow-up on review comments in a timely manner.

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #499 (31840a9) into master (28cdc1d) will decrease coverage by 0.25%.
The diff coverage is 72.41%.

❗ Current head 31840a9 differs from pull request most recent head d016254. Consider uploading reports for the commit d016254 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
- Coverage   64.10%   63.84%   -0.26%     
==========================================
  Files         113      113              
  Lines        2747     2744       -3     
  Branches      457      457              
==========================================
- Hits         1761     1752       -9     
+ Misses        852      851       -1     
- Partials      134      141       +7     
Impacted Files Coverage Δ
...vigations/MainStackNavigator/LeaveChannelModal.tsx 25.71% <0.00%> (ø)
...omponents/navigations/MainStackNavigator/index.tsx 2.77% <ø> (ø)
...nt/src/components/navigations/MainTabNavigator.tsx 21.42% <ø> (ø)
.../src/components/navigations/RootStackNavigator.tsx 45.45% <ø> (ø)
client/src/components/pages/ChangePw.tsx 58.97% <ø> (ø)
client/src/components/pages/FindPw.tsx 89.65% <ø> (ø)
client/src/components/pages/ProfileUpdate.tsx 50.58% <ø> (ø)
client/src/components/pages/Report.tsx 52.63% <ø> (ø)
...src/components/pages/SignIn/SocialSignInButton.tsx 0.00% <ø> (ø)
client/src/components/pages/SignUp.tsx 58.22% <ø> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28cdc1d...d016254. Read the comment docs.

@hyochan hyochan added 🍗 enhancement New feature or request and removed 🎯 feature New feature 🍗 enhancement New feature or request labels Oct 8, 2021
@hyochan hyochan merged commit f8266dc into master Oct 8, 2021
@hyochan hyochan deleted the refactor/colors branch October 8, 2021 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant