feat(mgmt): add per-route scope enforcement on management HTTP port#118
Merged
Conversation
Introduce WithMgmtControlAuth option to apply a stricter auth gate (admin scope) to the cluster-mutating control endpoints (/evict, /clear, /trigger-expiration), while the observability surface (/stats, /config, /cluster/*, /dist/*) requires only read scope via WithMgmtAuth. Key changes: - Extract Policy.Verify() from Middleware() so auth logic lives in one place; Middleware is now thin sugar over Verify() + Next(). Verify returns *fiber.Error (fail-closed) instead of SendStatus. - Add controlAuthFunc field and WithMgmtControlAuth option to ManagementHTTPServer; extract wrapWithGate helper shared by both auth wrappers. - Exempt /health from auth — k8s liveness probes carry no credentials and a probe failure cascades into pod-restart loops. - Wire read-or-better and admin-only gates in the server binary. - Add unit tests for Verify() parity with Middleware() and integration tests pinning the Phase C2 auth posture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce WithMgmtControlAuth option to apply a stricter auth gate (admin scope) to the cluster-mutating control endpoints (/evict, /clear, /trigger-expiration), while the observability surface (/stats, /config, /cluster/, /dist/) requires only read scope via WithMgmtAuth.
Key changes: