chore(deps): bump buf to v1.66.0 and golang.org/x/net to v0.51.0#83
chore(deps): bump buf to v1.66.0 and golang.org/x/net to v0.51.0#83
Conversation
hyp3rd
commented
Feb 28, 2026
hyp3rd
commented
- Update BUF_VERSION in .project-settings.env and Makefile
- Update indirect Go module dependency golang.org/x/net (go.mod/go.sum)
- Update BUF_VERSION in .project-settings.env and Makefile - Update indirect Go module dependency golang.org/x/net (go.mod/go.sum)
There was a problem hiding this comment.
Pull request overview
This PR updates pinned tooling/dependency versions, aiming to keep the repo’s protobuf tooling and Go indirect dependencies current.
Changes:
- Bump
golang.org/x/netindirect dependency tov0.51.0(go.mod/go.sum). - Bump
BUF_VERSIONtov1.66.0in.project-settings.envandMakefile.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
go.mod |
Updates indirect module requirement for golang.org/x/net to v0.51.0. |
go.sum |
Updates checksums to match the new golang.org/x/net v0.51.0 version. |
Makefile |
Updates BUF_VERSION default to v1.66.0. |
.project-settings.env |
Updates BUF_VERSION to v1.66.0 for shared project settings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,5 +1,5 @@ | |||
| GOLANGCI_LINT_VERSION=v2.10.1 | |||
| BUF_VERSION=v1.65.0 | |||
| BUF_VERSION=v1.66.0 | |||
There was a problem hiding this comment.
BUF_VERSION is bumped here, but the CI workflows that source .project-settings.env only read GO_VERSION/GOLANGCI_LINT_VERSION and never consume BUF_VERSION. As a result, this setting currently doesn't affect tooling versions in CI. Either plumb BUF_VERSION into the relevant workflow/Make targets or drop it to avoid a misleading configuration knob.
| BUF_VERSION=v1.66.0 |
|
|
||
| GOLANGCI_LINT_VERSION ?= v2.10.1 | ||
| BUF_VERSION ?= v1.65.0 | ||
| BUF_VERSION ?= v1.66.0 |
There was a problem hiding this comment.
BUF_VERSION is updated here, but it doesn't appear to be used anywhere to actually pin/install buf (the Makefile installs github.com/bufbuild/buf/cmd/buf@latest). This makes the version bump effectively a no-op and can mislead readers into thinking buf is locked to v1.66.0. Consider either wiring BUF_VERSION into the buf install/prepare target (so installs are reproducible) or removing the variable entirely if it's not intended to control anything.
| BUF_VERSION ?= v1.66.0 |
…utdown - Cancel the background jobs context when Stop is signaled - Exit eviction/expiration loops on ctx.Done and stop associated tickers - Make Stop() send on the stop channel best-effort and clear bgCancel after use
