update hightable and implement dataframe v2 #30
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@platypii do you want to review this one?
I'm not really sure about the dataframe I created for the iceberg files.
Three things to think about:
numRows. In this implementation, I put-1in the row number (as we only support numbers - it could also be NaN) andundefinedin the cells[1000, 2000]. Is it right? If so, do you have an idea of how we could improve? maybe asking for[0, rowEnd]and cache everything to avoid later fetches (consumes more memory)Re cache: we might want to implement hyparam/hightable#232, and use it here, to simplify the cache management.