Skip to content

handle cell that resolves to undefined#110

Merged
severo merged 1 commit intomasterfrom
108-handle-resolved-to-undefined
Apr 8, 2025
Merged

handle cell that resolves to undefined#110
severo merged 1 commit intomasterfrom
108-handle-resolved-to-undefined

Conversation

@severo
Copy link
Copy Markdown
Contributor

@severo severo commented Apr 8, 2025

fixes #108

Screencast.From.2025-04-08.11-09-44.webm.mp4

@severo severo changed the title handle undefined resolved value handle cell that resolves to undefined Apr 8, 2025
@severo severo requested review from bleakley and platypii April 8, 2025 09:12
@bleakley
Copy link
Copy Markdown
Contributor

bleakley commented Apr 8, 2025

Do we want to visually distinguish between cells with empty strings and cells with no data? That would make sense from a data cleaning perspective. @platypii what do you think?

@severo severo force-pushed the 108-handle-resolved-to-undefined branch from daaca26 to 15c5165 Compare April 8, 2025 14:45
Copy link
Copy Markdown
Contributor

@platypii platypii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bleakley good question on how to render empty string vs undefined vs null. We should experiment with the best approach there.

But technically that behavior can be customized with the stringify prop, whereas the loading-on-undefined thing needed this fix. Thanks @severo

@severo severo merged commit 8890377 into master Apr 8, 2025
8 checks passed
@severo severo deleted the 108-handle-resolved-to-undefined branch April 8, 2025 20:20
@severo
Copy link
Copy Markdown
Contributor Author

severo commented Apr 8, 2025

OK, feel free to open a new issue if needed for the empty string/undefined/null question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There should be a difference between loading and cell undefined

3 participants