show a placeholder (blurred number) while row index is loading#131
Merged
show a placeholder (blurred number) while row index is loading#131
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a busy state for row headers to indicate when the row index is loading. It adds a new optional busy prop to the RowHeader component and adjusts the HighTable component to pass this prop based on the data availability.
- Adds busy prop to RowHeader to reflect loading state via the aria-busy attribute.
- Updates HighTable to conditionally set the busy prop when dataIndex is undefined.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/RowHeader/RowHeader.tsx | Adds busy prop and applies aria-busy for accessibility. |
| src/components/HighTable/HighTable.tsx | Passes busy prop to RowHeader based on dataIndex availability. |
Files not reviewed (1)
- src/components/HighTable/HighTable.module.css: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #128
Screencast.From.2025-04-23.17-24-47.mp4