Use data attributes, and add aria-colindex#139
Merged
Conversation
severo
changed the title
Instead of `aria-posinset` and `aria-setsize`, use `data-order-by-index` and `data-order-by-size`, to avoid misleading the users. Multicolumn sort is not supported by ARIA at the moment, so didn't try to be clever. See w3c/aria#283
… let edit the content" This reverts commit dc312f9. It's not needed (and even recommended against, see https://www.w3.org/WAI/ARIA/apg/patterns/grid/#wai-ariaroles,states,andproperties) because aria-readonly is already set on the "grid" role element.
severo
force-pushed
the
control-sort-with-keyboard
branch
from
825d730 to
83e1ff9
Compare
severo
changed the title
Contributor
Author
|
Merging, as it's nothing crucial or hard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
data-attributes instead of hackingaria-attributes: Instead ofaria-posinsetandaria-setsize, usedata-order-by-indexanddata-order-by-sizeto avoid misleading the users. ARIA does not currently support multicolumn sort, so don't try to be clever. See aria-sort should be allowed on multiple columns w3c/aria#283aria-colindexto the cells. It's explicit and will be useful when implementing column hiding (Feature: hide columns #3)