Conversation
Note that we remove the unused top pending state
This reverts commit 1ca438c.
severo
changed the title
9 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds keyboard support to column header interactions for sorting columns.
- Replace mouse event handling with keyboard events in the onClick prop.
- Introduce an onKeyDown handler to capture Enter and Space keys for sorting actions.
- Update tests to verify that the header responds to keyboard events.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/components/ColumnHeader/ColumnHeader.tsx | Updated onClick signature and added onKeyDown event handling. |
| src/components/ColumnHeader/ColumnHeader.test.tsx | Added tests for keyboard-triggered click events. |
platypii
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #30
Note that this PR is against https://github.com/hyparam/hightable/tree/navigate-through-keyboard, ie #140