Skip to content

add a top border element#170

Merged
severo merged 3 commits intomasterfrom
add-static-border-top
May 16, 2025
Merged

add a top border element#170
severo merged 3 commits intomasterfrom
add-static-border-top

Conversation

@severo
Copy link
Copy Markdown
Contributor

@severo severo commented May 16, 2025

Before:

Screencast.From.2025-05-16.19-06-33.mp4

After:

Screencast.From.2025-05-16.19-06-07.mp4

@severo
Copy link
Copy Markdown
Contributor Author

severo commented May 16, 2025

A test is failing, but... a comment warned us the selector was brittle :)

const scrollDiv = container.querySelector('.myclass > div') // brittle selector, be careful

@severo severo merged commit 2835e62 into master May 16, 2025
10 checks passed
@severo severo deleted the add-static-border-top branch May 16, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants