[BREAKING] make eventTarget and fetch optional + DataFrame generic#254
Merged
[BREAKING] make eventTarget and fetch optional + DataFrame generic#254
Conversation
- there is no reason why eventTarget should be defined in sortable dataframe. If not async operation (fetch) is needed to get the sorted values and row numbers, no need for an event target. - make the dataframe generic, to be able to have pass the type of the metadata to consumers. - fix a comment It should be a "major" version of hightable anyway, since eventTarget
platypii
approved these changes
Aug 19, 2025
severo
changed the title
Note that it was not exported, so it's not a breaking change.
Contributor
Author
|
It ended up not so trivial! But I think it's better to have a simpler way to create dataframes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eventTargetshould be defined in sortable dataframe. If no async operation (fetch) is needed to get the sorted values and row numbers, no need for an event target.fetchshould always be included. A static dataframe has nothing to fetch.