Skip to content

Exclusive sort#267

Merged
platypii merged 4 commits intomasterfrom
exclusive-sort
Sep 9, 2025
Merged

Exclusive sort#267
platypii merged 4 commits intomasterfrom
exclusive-sort

Conversation

@bleakley
Copy link
Copy Markdown
Contributor

@bleakley bleakley commented Sep 8, 2025

In this state multiple columns can be sortable but only one column can be sorted at a time.

@bleakley bleakley requested a review from severo September 8, 2025 22:39
Comment thread src/components/TableHeader/TableHeader.tsx Outdated
Comment thread src/helpers/dataframe/sort.ts Outdated
@bleakley bleakley requested a review from severo September 9, 2025 18:09
Comment thread src/helpers/dataframe/sort.ts
Comment thread src/helpers/dataframe/sort.ts
Comment thread src/helpers/dataframe/types.ts
@bleakley bleakley requested a review from severo September 9, 2025 20:08
Copy link
Copy Markdown
Contributor

@severo severo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment, but great new feature

Comment thread src/helpers/dataframe/sort.ts Outdated
@severo
Copy link
Copy Markdown
Contributor

severo commented Sep 9, 2025

fyi, the merge seems blocked due to:

Commits must have verified signatures.

cc @platypii

Copy link
Copy Markdown
Contributor

@platypii platypii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed locally with storybook, code looks good 👍

@platypii platypii merged commit 353fa05 into master Sep 9, 2025
10 checks passed
@platypii platypii deleted the exclusive-sort branch September 9, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants