Skip to content

extract and sort the colors, and reduce their number#283

Merged
severo merged 2 commits intomasterfrom
simplify-colors
Sep 24, 2025
Merged

extract and sort the colors, and reduce their number#283
severo merged 2 commits intomasterfrom
simplify-colors

Conversation

@severo
Copy link
Copy Markdown
Contributor

@severo severo commented Sep 23, 2025

The styles are nearly the same, but it will be easier to customize.

Screencast.From.2025-09-23.18-38-37.mp4

@severo severo requested a review from Copilot September 23, 2025 16:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the CSS custom properties (CSS variables) for colors in the HighTable component by introducing a systematic naming convention and consolidating the color palette. The changes replace the old scattered color definitions with a more organized system using "hy-" prefixed variables, reducing the total number of color variables while maintaining the same visual appearance.

  • Introduced systematic color naming with --hy-color-*, --hy-accent-*, and --hy-highlight-* prefixes
  • Consolidated color definitions from scattered variables into organized color groups
  • Updated all color references to use the new systematic naming convention

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/HighTable.module.css
@severo severo requested a review from platypii September 23, 2025 16:47
@severo
Copy link
Copy Markdown
Contributor Author

severo commented Sep 23, 2025

asking for a review @platypii, because it might slightly break customized styles if they used --light-border-color (low possibility that it affects any user at all). I think we can increment the minor number, just in case.

Copy link
Copy Markdown
Contributor

@platypii platypii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification

@severo severo merged commit 2c63fb3 into master Sep 24, 2025
10 checks passed
@severo severo deleted the simplify-colors branch September 24, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants